Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected en-us growth rate names #667

Merged
merged 4 commits into from
Apr 28, 2023
Merged

Corrected en-us growth rate names #667

merged 4 commits into from
Apr 28, 2023

Conversation

DDriggs00
Copy link
Contributor

Previously, the names for the erratic and fluctuating en-us growth rates were listed incorrectly.

Note that Language id 6 (German) also needs corrected by someone who speaks German.

@Naramsim
Copy link
Member

Thanks for this PR. I see that the names have changed. Would you be so kind to open the same PR or better an issue over at veekun/pokedex and check what the guys (@magical) say? Maybe the names we are currently using are for past generations.

If we end up accepting your contribution. Maybe it's worth changing the https://github.com/PokeAPI/pokeapi/blob/master/data/v2/csv/growth_rates.csv file as well. (And check the formulas to be still correct)

@DDriggs00
Copy link
Contributor Author

I created a pull request, but that repo appears unmaintained

@helblinglilly
Copy link
Contributor

Note that Language id 6 (German) also needs corrected by someone who speaks German.

Is this still required? I'd be happy to do that tomorrow?

@Naramsim
Copy link
Member

Naramsim commented Jan 7, 2023

@helblingjoel not required as of now. I'll ping you in the future if needed. Thanks a lot!

@Naramsim Naramsim merged commit c32037b into PokeAPI:master Apr 28, 2023
@Naramsim
Copy link
Member

@helblingjoel I just merged the PR, if you like you could update the german names and open a new one

@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In 45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and you will be able to review the entire API.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

You can see the Pull Request deployed at our staging environment when CircleCI deploy will be finished (check the started time of the last build).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants